src: fix closing weak HandleWraps on GC#29640
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
src: fix closing weak HandleWraps on GC#29640addaleax wants to merge 2 commits intonodejs:masterfrom
HandleWraps on GC#29640addaleax wants to merge 2 commits intonodejs:masterfrom
Conversation
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs#29317
nodejs-github-bot
added
the
c++
Collaborator
bcoe
approved these changes
Sep 21, 2019
Member
Author
|
This currently breaks CI for the unrelated #28960, so feel free to 👍 this comment to approve fast-tracking. |
addaleax
added
fast-track
Collaborator
Trott
reviewed
Sep 21, 2019
Trott
approved these changes
Sep 21, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
I have a question but nothing that should block this from landing and fixing CI. My comment can be addressed in another PR or not at all.
Collaborator
Collaborator
bcoe
approved these changes
Sep 21, 2019
Contributor
|
Landed in e74f308 |
Merged
This was referenced Sep 25, 2019
addaleax
added a commit
to nodejs/quic
that referenced
this pull request
Sep 29, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
pushed a commit
to nodejs/quic
that referenced
this pull request
Oct 1, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
added a commit
to nodejs/quic
that referenced
this pull request
Oct 2, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell
pushed a commit
to nodejs/quic
that referenced
this pull request
Oct 2, 2019
In 0af62aa, this was overlooked, with it possibly leading to hard crashes. Refs: nodejs/node#29317 PR-URL: nodejs/node#29640 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 0af62aa, this was overlooked, with it
possibly leading to hard crashes.
Thanks to @bcoe for pointing me to this as the cause of the failure in https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/28455/console.
Refs: #29317
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes